-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: PyPerf: Aarch64 support #287
base: master
Are you sure you want to change the base?
Conversation
Full matrix of feature tests for py-spy & PyPerf across all desired versions. This is what I suggested in #287 and finally got around to implement. I rather have these in place before performing any other changes on PyPerf/py-spy.
Full matrix of feature tests for py-spy & PyPerf across all desired versions. This is what I suggested in #287 and finally got around to implement. I rather have these in place before performing any other changes on PyPerf/py-spy.
x86_64: build should pass, and hopefully will the tests. Aarch64: I managed to build container, exe still failing. Tested against Python 3.8 on kernel5.11, Python symbols all get |
Got it running just fine against Python 2 (well, as the description says). Native stacks still fail, but I get good Python 2 symbols & including class names. Very good |
Python 3 works now |
Native stacks are broken on x86_64, I'll fix that and then continue to fixing it on Aarch64. So far on Aarch64 I'm seeing a similar error to libunwind/libunwind#113 but it's not clear if that error is transient or not. |
Description
Support PyPerf running on Aarch64.
This currently passes "sanity" - works on Python 2.7.18 on Ubuntu 20.04 kernel
5.13.0-1008-aws
. I am opening this PR to document what's left to be done & the tests we should run on it.This depends on:
TODOs
Testing
x86_64:
get_stack_offset
on 4.14get_stack_offset
on 4.18get_stack_offset
on 5.11get_stack_offset
on 5.16get_fs_offset
on 4.14get_fs_offset
on 4.18get_fs_offset
on 5.11get_fs_offset
on 5.16Aarch64: